Make mx.compile work on Windows #1697
Open
+166
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awni
reviewed
Dec 20, 2024
mlx/backend/common/compiled_cpu.cpp
Outdated
Comment on lines
196
to
219
| #ifdef _MSC_VER | ||
| const VisualStudioInfo& info = GetVisualStudioInfo(); | ||
| std::string libpaths; | ||
| for (const std::string& lib : info.libpaths) { | ||
| libpaths += fmt::format(" /libpath:\"{0}\"", lib); | ||
| } | ||
| std::string build_command = fmt::format( | ||
| "\"" | ||
| "cd /D \"{0}\" && " | ||
| "\"{1}\" /LD /EHsc /MD /Ox /nologo /std:c++17 \"{2}\" " | ||
| "/link /out:\"{3}\" {4} >nul" | ||
| "\"", | ||
| std::filesystem::temp_directory_path().string(), | ||
| info.cl_exe, | ||
| source_file_name.str(), | ||
| shared_lib_name.str(), | ||
| libpaths); | ||
| #else | ||
| std::string build_command = fmt::format( | ||
| "g++ -std=c++17 -O3 -Wall -fPIC -shared '{0}' -o '{1}'", | ||
| source_file_path, | ||
| shared_lib_path); | ||
| #endif | ||
| auto return_code = system(build_command.c_str()); |
There was a problem hiding this comment.
I think it would be good to encapsulated the compiler into it's own class to contain the if-defs and make this more maintainable / extensible.
Something like:
static std::string JitCompiler::build_command(
const std::string& source_file_path, const std::string& shared_lib_name)
// And we could include any special source code headers needed in the class as well.
static std::string JitCompiler::get_header()There was a problem hiding this comment.
Then again.. we only have three compilers (g++, clang, msvc) right now.. so I'm also ok to wait and see if we need to generalize this again.
There was a problem hiding this comment.
I think it is good timing to move the code to a separate file, I have updated the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1513.
This PR adds code to invoke MSVC on Windows. Most of the new code are about getting the paths information of Visual Studio.